RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottlinger
changed the title
ottlinger
reviewed
May 11, 2024
ottlinger
reviewed
May 11, 2024
Claudenw
force-pushed
the
RAT-324_tests_to_validate_that_UI_options
branch
from
c8cdfaf
to
8f8b8f5
Compare
|
I don't like the fix for the test errors, but there seems to be no other way. I was planning on resolving more spotbugs before merging but this at least has the tests and many of the spotbugs resolved. |
ottlinger
reviewed
May 16, 2024
ottlinger
reviewed
May 16, 2024
ottlinger
reviewed
May 16, 2024
ottlinger
reviewed
May 16, 2024
apache-rat-core/src/main/java/org/apache/rat/license/SimpleLicense.java
Outdated
Show resolved
Hide resolved
ottlinger
reviewed
May 16, 2024
ottlinger
reviewed
May 16, 2024
|
Thanks for your work and a cool catch solving RAT-265 on the way! :) |
|
I need to resolve some conflicts. I'll try to get to that today/this evening. |
ottlinger
reviewed
May 18, 2024
ottlinger
reviewed
May 18, 2024
ottlinger
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed RAT-265
Added initial tests for command line processing